NewtonSoftJsonSerializer throws a StackOverflow exception when trying to deserialize an object field

[Arkatufus]

Version Information
Version of Akka.NET? 1.4.49/1.5.0
Which Akka.NET Modules? Akka

Describe the bug
NewtonSoftJsonSerializer throws a StackOverflow exception when trying to deserialize a class with an object field/property when assingned a JObject instance.

To Reproduce
Steps to reproduce the behavior:
#6503

Expected behavior
Should deserialize successfully

Actual behavior
Throws StackOverflow

Environment
Any

[Aaronontheweb]

We'll release a fix for this in 1.4.50 and 1.5.1

[Aaronontheweb]

Is there any relation to these types of issues? #4463

i.e. is this all Newtonsoft.Json type-conversion issues?

[Arkatufus]

That issue is actually by design, we are replacing int, decimal, and float with a JObject so that we can preserve the value type inside an anonymous object across the wire.

[Arkatufus]

Note that we're not replacing long and double as those are actually the default Newtonsoft Json behavior

[Aaronontheweb]

That issue is actually by design, we are replacing int, decimal, and float with a JObject so that we can preserve the value type inside an anonymous object across the wire.

Which issue?

[Arkatufus]

I was replying to your comment on issue #4463

[Aaronontheweb]

Ah ok, so close that then?

[Arkatufus]

Either close that issue, or reconsider our JSON wire format to not replace value types

[Aaronontheweb]

Done

[Arkatufus]

These are the corresponding lines:

akka.net/src/core/Akka/Serialization/NewtonSoftJsonSerializer.cs

Lines 432 to 438 in f92c609

	if (value is int || value is decimal || value is float)
	{
	writer.WriteStartObject();
	writer.WritePropertyName("$");
	writer.WriteValue(GetString(value));
	writer.WriteEndObject();
	}

akka.net/src/core/Akka/Serialization/NewtonSoftJsonSerializer.cs

Lines 455 to 464 in f92c609

	private object GetString(object value)
	{
	if (value is int)
	return "I" + ((int)value).ToString(NumberFormatInfo.InvariantInfo);
	if (value is float)
	return "F" + ((float)value).ToString(NumberFormatInfo.InvariantInfo);
	if (value is decimal)
	return "M" + ((decimal)value).ToString(NumberFormatInfo.InvariantInfo);
	throw new NotSupportedException();
	}