Json net 7 #1128
Merged
Json net 7 #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return res; | ||
| } | ||
| //The JObject is not of our concern, let Json.NET deserialize it. | ||
| return j.ToObject(type, parent._serializer); |
There was a problem hiding this comment.
This does the magic, if we get a JObject, we can pass in the same settings as we use for other serialzation, and things turns out correct :)
|
I'm kind of the opinion that we should just pull this in anyway buuuuuuuuuut What sort of risk is there for this change to cause Akka.NET to be incompatible with other stuff that depends on JSON.NET, such as ASP.NET MVC? |
|
@Aaronontheweb I have absolutely no idea :) maybe a simple assembly version redirect would work in those cases. |
|
A BRAVE NEW WORLD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Json.NET and removes the old DU hacks we had in the serializer.
This closes: #1127 #1126 #999 #827