Hocon include support #1169
Merged
Hocon include support #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohh, shiny "needs review" auto label :) |
| { | ||
| var json = JsonConvert.SerializeObject(source); | ||
| var config = ParseString(json); | ||
| return config; |
There was a problem hiding this comment.
This lets us create Hocon Configs from typed objects.
a convenience method only, but opens up for using objects as includes, or creating typed configuration support.
|
the failing test "ConfigurationSpec.CanCreateConfigFromSourceObject" is fixed by my other PR. |
|
If the tests are re-run, does it run on top of newly merged PR's ? |
|
@rogeralsing it runs exactly the code that you have in your PR - so anything that's in |
Added Hocon Include support Added Hocon Include substitution support Added more Hocon tests Changed includes from single quote to double quotes. (spec says single quote in the spec text, but all examples and code on JVM uses double quotes)
|
I updated my branch to include the racy Json config fix merged yesterday. everything pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1164
This allows us to use Hocon includes:
The 'some resource' can then be resolved by an optional resolver callback. so the resource could be a file on disk, an url, or whatever you want that could result in a new hocon sub config.
see inline comments for explanations of the code to help the review