added remote metrics #1722
Merged
added remote metrics #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxim-s are there are any unit tests for this we should add? |
maxim-s
force-pushed
the
remote-metrics
branch
from
c84831b
to
22b559c
Compare
|
@Aaronontheweb done! |
|
Great! I'll review this soon |
| { | ||
| public override IRemoteMetrics CreateExtension(ExtendedActorSystem system) | ||
| { | ||
| if (system.Settings.Config.GetString("akka.remote.log-frame-size-exceeding").ToLowerInvariant() == "off") |
There was a problem hiding this comment.
yep, this is the same as the JVM - this feature is only really used for Akka.Remote / Cluster users who want to keep some historical track as to whether or not they're close to hitting the ceiling on the maximum frame size.
|
Awesome job @maxim-s - this is great work. |
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.