Implemented guardian-supervisor-strategy hocon setting
#1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a duplicate of #1525 :) |
|
Doh! |
|
yep, right and theoretically this PR would also need this. I assume that's the reason why @JeffCyr has changed the implementation of these tests compared to the scala version. |
JeffCyr
force-pushed
the
supervisorstrategyconfigurator
branch
from
2f49119
to
cb07731
Compare
|
@Silv3rcircl3 @Aaronontheweb I didn't understand why the scala version used the EventFilter, don't you think it is a bit zealous? The test is more about asserting that the actor has stopped than observing that an exception was thrown from the actor. |
|
|
||
| a.Tell("die"); | ||
|
|
||
| var t = probe.ExpectTerminated(a); |
There was a problem hiding this comment.
Yeah, this looks fine to me - don't think we need #1753 to complete this. The ExpectTerminated does the job.
Aaronontheweb
added a commit
that referenced
this pull request
Mar 7, 2016
Implemented `guardian-supervisor-strategy` hocon setting
|
Compared to the JVM source and it seemed complete and correct to me. |
This was referenced Mar 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PullRequest makes it possible to change the User Guardian supervision strategy with the guardian-supervisor-strategy` hocon setting.