Member.UpNumber fix #1799
Merged
Member.UpNumber fix #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return new Member(uniqueAddress, 0, status, roles); | ||
| return new Member(uniqueAddress, upNumber, status, roles); |
There was a problem hiding this comment.
Oh wow, nice catch. I could see this being responsible for some fun issues with Cluster rejoin scenarios too.
|
Looks like the timestamp on this commit is 29 days old, so it didn't show up on TeamCity - would you mind changing the timestamp on your commit? http://stackoverflow.com/a/31540373/377476 This will allow our CI system to scoop it up. Great job @zbynek001 👍 |
|
This is ready for merge once CI passes - it fixes an obvious bug in Akka.Cluster but the test suite might reveal others, and possibly faulty assumptions with the test suite. |
ActorPath operator / fix for empty element ClusterSharding MemberAgeComparer reverse order
| @@ -254,7 +254,8 @@ public bool Equals(ActorPath other) | |||
| var a = path; | |||
| foreach (string element in name) | |||
| { | |||
| a = a / element; | |||
| if(!string.IsNullOrEmpty(element)) | |||
| a = a / element; | |||
There was a problem hiding this comment.
I've also added fix for ActorPath operator / used in singleton proxy. This way it's also handled in akka
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1784.
Member.UpNumber is not being propagated across cluster
MemberAgeComparer is sorting in a reverse order then it should