EndpointRegistry fixes #1862
EndpointRegistry fixes #1862
Conversation
Aaronontheweb
force-pushed
the
fix-endpoint-registry
branch
from
bd53418
to
c1bcd13
Compare
| @@ -193,9 +193,6 @@ EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PersistenceBenchmark", "benchmark\PersistenceBenchmark\PersistenceBenchmark.csproj", "{39E6F51F-FA1E-4C62-B8F8-19065DE6D55D}" | |||
| EndProject | |||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{A59BAE84-70E2-46A0-9E26-7413C103E2D7}" | |||
| ProjectSection(SolutionItems) = preProject | |||
There was a problem hiding this comment.
No idea what this was for. Deleted it.
|
This one is ready to review cc @annymsMthd |
|
Hrmmm.... hold the phone - found another potential issue that could be part of #1700 |
|
Ok, did a pretty full review of the diff on #1755 - only thing I could come up with was that we had two bugs that offset each other and I only fixed one of them in 1.0.6. One bug had us pass in the wrong UID to the ProtocolStateActor all the way down from the This PR fixes the second bug, which was caused by an issue with the |
|
Great work |
Fixed numerous issues with the
EndpointRegistryand added specs to cover - should resolve #1845 and others.