Changed cluster client api to use IEnumerable for InitialContacts. #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need probably api approval. But i'm going to wait after review. |
|
|
Aaronontheweb
requested changes
Apr 11, 2017
| @@ -113,7 +113,7 @@ public static ClusterClientSettings Create(Config config) | |||
| /// <param name="reconnectTimeout">TBD</param> | |||
| /// <exception cref="ArgumentException">TBD</exception> | |||
| public ClusterClientSettings( | |||
| IImmutableSet<ActorPath> initialContacts, | |||
| IEnumerable<ActorPath> initialContacts, | |||
| @@ -69,15 +70,13 @@ protected ClusterClientStartSpec(ClusterClientStartSpecConfig config) : base(con | |||
|
|
|||
| protected override int InitialParticipantsValueFactory => 3; | |||
|
|
|||
| private ImmutableHashSet<ActorPath> InitialContacts | |||
| private IEnumerable<ActorPath> InitialContacts | |||
| { | |||
| get | |||
| { | |||
| //return new List<ActorPath>().ToImmutableHashSet(); | |||
- Updated usage patterns in tests and examples
|
@Danthar We can't merge this Pull Request anymore, because Cluster Tools become stable. Just make another constructor and overloaded method |
|
I was going to update this PR. But I changed my mind. Adding a constructor overload defeats the purpose of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And updated usage patterns in tests and examples