Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-docs] Update docfx config to support new proj #2669

Merged
merged 1 commit into from May 15, 2017

Conversation

sean-gilliam
Copy link
Member

This PR updates the docfx configuration file to support .netStandard
project files.

docs/docfx.json Outdated
"dest": "api"
"dest": "api",
"properties": {
"TargetFramework": "netstandard1.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why netstandard? Not net45?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something, we don't have different public APIs between net45 and netstandard. So I chose the later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have. For example right now we dont have Akka.IO on netcore. We don't have some members related to System.Configuration

This PR updates the docfx configuration file to support .netStandard
project files.
@sean-gilliam
Copy link
Member Author

Changed to TargetFramework net45, included missing projects, and formatted the json.

@Danthar Danthar merged commit fc2f009 into akkadotnet:v1.3 May 15, 2017
@sean-gilliam sean-gilliam deleted the api-docs branch May 15, 2017 15:01
Aaronontheweb pushed a commit to Aaronontheweb/akka.net that referenced this pull request Jun 28, 2017
This PR updates the docfx configuration file to support .netStandard
project files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants