Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Akka.Serialization.Hyperion dependency #3003

Merged
merged 3 commits into from
Aug 18, 2017

Conversation

Aaronontheweb
Copy link
Member

cc @Ralf1108 - this will fail to compile if the build server is the issue.

@@ -70,7 +70,8 @@ public HyperionSerializer(ExtendedActorSystem system, HyperionSerializerSettings
preserveObjectReferences: settings.PreserveObjectReferences,
versionTolerance: settings.VersionTolerance,
surrogates: new[] { akkaSurrogate },
knownTypes: provider.GetKnownTypes()));
knownTypes: provider.GetKnownTypes(),
ignoreISerializable:true));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, I'm fine with leaving this setting on. ISerializable is dangerous and shouldn't be used for anything other than local serialization, not cross-network.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aaronontheweb But we don't have any alternatives for Exceptions. We can use only ISerializable serialization

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old behavior would be to ignore it because ISerializable support in Hyperion was introduced only in latest release.
Maybe you can just release a fixed version for "Akka.Serialization.Hyperion" without ISerialization support and discuss this afterwards ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this PR is not about using ignoreISerializable or not. Its about fixing the package. Default value is false, so set it at false. And lets have the discussion on when to turn this option on, a different time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old behavior would be to ignore it because ISerializable support in Hyperion was introduced only in latest release.

Agreed. We weren't using it before. Status quo.

@Aaronontheweb Aaronontheweb changed the title ignore ISerializable set to true fix Akka.Serialization.Hyperion dependency Aug 17, 2017
@Danthar Danthar merged commit 520c0f3 into akkadotnet:dev Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants