Sharding - RestartShard escapes into userspace #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just double checked this against the JVM code base and it looks like they have the same bug. Nice catch. LGTM. |
Aaronontheweb
pushed a commit
that referenced
this pull request
Jun 14, 2018
NickPolyder
added a commit
to NickPolyder/akka.net
that referenced
this pull request
Jun 18, 2018
This was referenced Aug 22, 2018
NickPolyder
added a commit
to NickPolyder/akka.net
that referenced
this pull request
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a possibility that the
ShardRegion.RestartShardmessage escapes into userspace. This can cause issues in customExtractEntityIdimplementations.This can happen, when the
RestartShardmessage gets into ShardBuffers here:akka.net/src/contrib/cluster/Akka.Cluster.Sharding/ShardRegion.cs
Line 560 in d732274
and later is send to
Shard