Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port KeepAliveConcat and UnfoldFlow #3560

Merged
merged 5 commits into from
Aug 8, 2018

Conversation

alex-bogomaz
Copy link
Contributor

Hi,

please review this port of KeepAliveConcat and UnfoldFlow streams stages.
This is for issue #3234.

Copy link
Contributor

@marcpiechura marcpiechura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍


#region Logic

private sealed class Logic : TimerGraphStageLogic, IInHandler, IOutHandler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an test that verifies that the stage keeps going if the source completes but items are still in the buffer ? Previously I’ve called SetKeepGoing In PreStart and I’m not 100% sure if you need to do it too or if it is handled implicitly since you’ve overridden OnUpstreamFinish

@alex-bogomaz
Copy link
Contributor Author

@marcpiechura - I added 1 tests that checks that KeepAliveConcat still emits buffered elements after upstream completes. Elements go through KeepAliveConcat with sufficiently large time-out to keep all them in buffer, than upstream completes and test check if elements are still emitted after that.

@marcpiechura
Copy link
Contributor

@alex-bogomaz thanks for verifying it !

@marcpiechura marcpiechura merged commit a8f81cc into akkadotnet:dev Aug 8, 2018
@marcpiechura marcpiechura added this to the 1.3.9 milestone Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants