-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port KeepAliveConcat and UnfoldFlow #3560
Port KeepAliveConcat and UnfoldFlow #3560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall 👍
|
||
#region Logic | ||
|
||
private sealed class Logic : TimerGraphStageLogic, IInHandler, IOutHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an test that verifies that the stage keeps going if the source completes but items are still in the buffer ? Previously I’ve called SetKeepGoing
In PreStart
and I’m not 100% sure if you need to do it too or if it is handled implicitly since you’ve overridden OnUpstreamFinish
@marcpiechura - I added 1 tests that checks that |
@alex-bogomaz thanks for verifying it ! |
Hi,
please review this port of
KeepAliveConcat
andUnfoldFlow
streams stages.This is for issue #3234.