Include manifest or class in missing serializer failure if possible #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Jan 25, 2019
| @@ -183,7 +183,7 @@ public object Deserialize(byte[] bytes, int serializerId, Type type) | |||
| { | |||
| if (!_serializersById.TryGetValue(serializerId, out var serializer)) | |||
| throw new SerializationException( | |||
| $"Cannot find serializer with id [{serializerId}]. The most probable reason" + | |||
| $"Cannot find serializer with id [{serializerId}] (class [{type?.Name}]). The most probable reason" + | |||
There was a problem hiding this comment.
Yes, this is a significant usability improvement. I love it.
ismaelhamed
force-pushed
the
extra-details-in-serializer-not-found-failure
branch
from
4869db9
to
68e6e28
Compare
ismaelhamed
force-pushed
the
extra-details-in-serializer-not-found-failure
branch
from
68e6e28
to
b5c9300
Compare
|
thanks @ismaelhamed ! |
This was referenced Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got one of this exceptions early today when switching to a very old branch. Figured out we were missing something #26225