Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnPersistRejected now logs an error with the complete stacktrace #3763

Merged

Conversation

Projects
None yet
2 participants
@ismaelhamed
Copy link
Contributor

commented Apr 24, 2019

As an user I want the complete stacktrace when persistence of an event is rejected. Plus IMO any issue with persistence is serious enough to log an error instead. I checked, and the JVM is logging an error too.

@Aaronontheweb Aaronontheweb added this to the 1.3.13 milestone Apr 24, 2019

@Aaronontheweb Aaronontheweb merged commit 5ca783f into akkadotnet:dev Apr 25, 2019

8 checks passed

continuous-integration/nuget-pack Finished TeamCity Build Akka.NET :: Akka.NET PR Build : Running
Details
continuous-integration/windows-build Finished TeamCity Build Akka.NET :: Akka.NET Windows Build : Running
Details
continuous-integration/windows-multinode-tests Finished TeamCity Build Akka.NET :: Akka.NET Windows MultiNodeTests : Tests passed: 98
Details
continuous-integration/windows-multinode-tests-netcore Finished TeamCity Build Akka.NET :: Akka.NET Windows MultiNode Tests (.NET Core) : Tests passed: 98
Details
continuous-integration/windows-perf-tests Finished TeamCity Build Akka.NET :: Akka.NET Windows Performance Tests : Tests passed: 131
Details
continuous-integration/windows-unit-tests Finished TeamCity Build Akka.NET :: Akka.NET Windows Unit Tests : Tests passed: 2508, ignored: 65
Details
continuous-integration/windows-unit-tests-netcore Finished TeamCity Build Akka.NET :: Akka.NET Windows Unit Tests (.NET Core) : Tests passed: 306, ignored: 8
Details
linux-netcore/unit-tests Finished TeamCity Build Akka.NET :: Akka.NET Linux Unit Tests (.NET Core) : Tests passed: 306, ignored: 8
Details
@Aaronontheweb

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Nice work @ismaelhamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.