[SpecFix] fixed Passivation_of_inactive_entities spec #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
May 21, 2019
| @@ -132,7 +132,7 @@ public void Passivation_of_inactive_entities_must_passivate_entities_when_they_h | |||
|
|
|||
| // Make sure "1" hasn't seen a message in 3 seconds and passivates | |||
| var timeSinceOneSawAMessage = DateTime.Now.Ticks - timeOneSawMessage; | |||
| probe.ExpectNoMsg(TimeSpan.FromSeconds(3) - TimeSpan.FromTicks(timeSinceOneSawAMessage)); | |||
| probe.ExpectNoMsg(TimeSpan.FromSeconds(3) - TimeSpan.FromTicks(timeSinceOneSawAMessage) - TimeSpan.FromMilliseconds(40)); | |||
There was a problem hiding this comment.
The fix here was simple - this spec, when it'd fail on the build server, would be for reasons like this:
Failed: Expected no messages during 00:00:00.9951057, instead we received <1 passivating> from [akka://AkkaSpec/system/sharding/myType/1/1#392767797] after 00:00:00.9946593
Expected: True
Actual: False
The issue in this case is that the time we were setting during the ExpectNoMsg period is more precise than what's allowed by the server's clock resolution. Thus, I padded the time by an additional 40ms - which should be plenty enough to make sure the test is still meaningful but a big enough margin to avoid having the test too tightly fitted.
|
Race conditions still aren't quite resolved yet even though the last build passed - have some more hardening to do on this spec. |
|
Covered via #3780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3786