New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRX Reporter for MultiNode tests #3904
TRX Reporter for MultiNode tests #3904
Conversation
Right now PR exists to verify that something will be reported to DevOps during a build. Please do not look into it yet :) |
c6cd1fe
to
4eccb0e
Compare
@Aaronontheweb Incrementalist is failing :( Can you direct into a possible issue? Before I will spend some hours on it. |
Yep, I'd be happy to take a look
…Sent from my iPhone
On Sep 5, 2019, at 3:21 PM, Valdis Zobēla ***@***.***> wrote:
@Aaronontheweb Incrementalist is failing :( Can you direct into a possible issue? Before I will spend some hours on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@Aaronontheweb seems that build related token does not allow to publish test results. I can verify that this is really so, then we have 2 possibilities:
What you will choose? |
@valdisz I'd just emit an XUnit-style report and I can come along later and output those TRX files up to Azure DevOps, which is what we do here: https://github.com/akkadotnet/akka.net/blob/dev/build.fsx#L232 This forces XUnit to emit a TRX file, which can be read and understood by Azure DevOps. And here is where we tell Azure DevOps how to consume it: akka.net/build-system/azure-pipeline.template.yaml Lines 34 to 39 in 37be6a5
So all we really need is just a way to output a .TRX file - does that make sense? |
src/core/Akka.MultiNodeTestRunner.AzureDevOps/Akka.MultiNodeTestRunner.AzureDevOps.csproj
Outdated
Show resolved
Hide resolved
75532c2
to
f6392fd
Compare
@Aaronontheweb you can look on this. |
@valdisz will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some changes.
I don't think this could should ship in separate projects - could you please put all of it under the Akka.MultiNodeTestRunner.Shared package instead? In its own namespace?
src/core/Akka.MultiNodeTestRunner.TrxReporter.Tests/ResultSummaryTests.cs
Outdated
Show resolved
Hide resolved
src/core/Akka.MultiNodeTestRunner.TrxReporter/Akka.MultiNodeTestRunner.TrxReporter.csproj
Outdated
Show resolved
Hide resolved
src/core/Akka.MultiNodeTestRunner.TrxReporter/Models/ResultSummary.cs
Outdated
Show resolved
Hide resolved
src/core/Akka.MultiNodeTestRunner.TrxReporter/Models/UnitTest.cs
Outdated
Show resolved
Hide resolved
@valdisz thanks for answering my question about the test structure - will review this again once the other changes are implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test reporter in TRX format for MulitNode tests. This will allow Azure DevOps and other tools, who understands TRX, to see actual test outcome.
It is possible to use either TeamCity or TRX reporter depending on parameter value:
-Dmulitnode.reporter=teamcity
or-Dmulitnode.reporter=trx
-Dmultinode.teamcity
switch is removed and build scripts are updated accordingly.PR is related to #3855