Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharding update #4354

Merged
merged 10 commits into from
Mar 27, 2020
Merged

Sharding update #4354

merged 10 commits into from
Mar 27, 2020

Conversation

zbynek001
Copy link
Contributor

@zbynek001 zbynek001 commented Mar 24, 2020

multiple sharding updates

* Keep track of Leaving and Exiting members in ShardRegion and
  attempt to register to coordinator at several of the oldest if
  they have status Leaving and Exiting. Include all up to and
  including the first member with status Up.
* Sending to wrong node doesn't matter, will be suppressed deadLetter.
* Same for the GracefulShutdownReq which already had that intention by
  sending to 2 oldest.

migrated from akka/akka#28470
@Aaronontheweb
Copy link
Member

@zbynek001 I'll review this tonight.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall - just have some very minor changes that we need.

@Aaronontheweb
Copy link
Member

@zbynek001 left some minor change requests for you

@Aaronontheweb Aaronontheweb merged commit 735aafb into akkadotnet:dev Mar 27, 2020
This was referenced Mar 31, 2020
@zbynek001 zbynek001 deleted the sharding-update3 branch July 16, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants