-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharding update #4354
Merged
Merged
Sharding update #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of PoisonPill migrated from akka/akka#28104
* Keep track of Leaving and Exiting members in ShardRegion and attempt to register to coordinator at several of the oldest if they have status Leaving and Exiting. Include all up to and including the first member with status Up. * Sending to wrong node doesn't matter, will be suppressed deadLetter. * Same for the GracefulShutdownReq which already had that intention by sending to 2 oldest. migrated from akka/akka#28470
zbynek001
force-pushed
the
sharding-update3
branch
from
March 26, 2020 20:25
e65c9e7
to
12a2e49
Compare
@zbynek001 I'll review this tonight. |
Aaronontheweb
requested changes
Mar 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall - just have some very minor changes that we need.
...contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingGracefulShutdownSpec.cs
Show resolved
Hide resolved
@zbynek001 left some minor change requests for you |
Aaronontheweb
approved these changes
Mar 27, 2020
This was referenced Mar 31, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple sharding updates
Log non-completed rebalance at warning level
migrated from Log non-completed rebalance at warning level akka/akka#28335
Shard region registration to more potential oldest
migrated from Shard region registration to more potential oldest, #28416 akka/akka#28470
Improve error message when coordinator not found
migrated from Improve error message when coordinator not found akka/akka#28576
Don't initialize durable keys when rememberEntities not used
migrated from Don't initialize Lmdb when rememberEntities not used, #28567 akka/akka#28568
Use dedicated message for PersistentShardCoodinator termination instead of PoisonPill
migrated from Use dedicated message for PersistentShardCoodinator termination instead of PoisonPill akka/akka#28104
Reconsider cluster.role..min-nr-of-members fallback
migrated from Reconsider cluster.role.<role-name>.min-nr-of-members fallback #28177 akka/akka#28203
Avoid dead letter for rebalance timeout msg
migrated from Avoid dead letter for rebalance timeout msg akka/akka#28274