Add live and current variant to AllEvents query and their documentation #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arkatufus still waiting on docs for this, right? |
|
yes, documentation should be in now |
Arkatufus
changed the title
|
@Arkatufus looks like we have a compilation error here |
Aaronontheweb
approved these changes
Jul 28, 2020
| _tickCancelable = Context.System.Scheduler.ScheduleTellRepeatedlyCancelable(refreshInterval, refreshInterval, Self, EventsByTagPublisher.Continue.Instance, Self); | ||
| } | ||
|
|
||
| protected override long ToOffset => long.MaxValue; |
There was a problem hiding this comment.
LGTM - need this to make IIsTimeForReplay function correctly on live queries
| @@ -37,42 +33,35 @@ public void ReadJournal_should_implement_IAllEventsQuery() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public virtual void ReadJournal_query_AllEvents_should_find_existing_events() | |||
| public virtual void ReadJournal_query_AllEvents_should_find_new_events() | |||
|
|
||
| probe.ExpectComplete(); | ||
| probe.ExpectNoMsg(TimeSpan.FromMilliseconds(500)); | ||
| // everything before "streaming" are not included, since exclusive offset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4521
Closes #4518
Updates:
AllEventsandCurrentAllEventsdocumentationAllPersistenceIdsandPersistenceIdsdocumentation