Parse expressions where possible to avoid penalties for .Compile()

[to11mtm]

This PR changes ExpressionExtensions.GetArguments() to parse expressions manually and avoid .Compile() wherever possible. This improves the speed of Expression based Props by 8-10%.

[Aaronontheweb]

LGTM, but need to approve API specs here since ExpressionExtensions is public @to11mtm

[Aaronontheweb]

API approvals are still failing for some reason....

[IgorFedchenko]

When I am running this locally, I can see that for all approval specs this line is removed in .received file:

[assembly: System.Reflection.AssemblyMetadataAttribute("RepositoryUrl", "https://github.com/akkadotnet/akka.net")]

But seems like there is also some problem with reporting - this is what I get locally, and AzDo says the same:

System.NullReferenceException
Object reference not set to an instance of an object.
   at ApprovalTests.Reporters.MultiReporter.Report(String approved, String received)
   at ApprovalTests.Approvers.FileApprover.ReportFailure(IApprovalFailureReporter reporter)
   at ApprovalTests.Core.Approver.Verify(IApprovalApprover approver, IApprovalFailureReporter reporter)
   at ApprovalTests.Approvals.Verify(IApprovalApprover approver, IApprovalFailureReporter reporter)
   at ApprovalTests.Approvals.Verify(IApprovalWriter writer, IApprovalNamer namer, IApprovalFailureReporter reporter)
   at ApprovalTests.Approvals.Verify(IApprovalWriter writer)
   at ApprovalTests.Approvals.Verify(String text, Func`2 scrubber)
   at Akka.API.Tests.CoreAPISpec.ApproveCore()

This RepositoryUrl line was added in this commit, with adding .net5 build support from 4 Jan. I will try to make it pass locally and let you know what has to be fixed. Or will fix our CI in separate PR.

[IgorFedchenko]

Err, sorry, seems like this was something related to my local installations. After installing .NET 5 I do get RepositoryUrl entry generated.

@to11mtm You just need to update Akka.API.Tests/CoreAPISpec.ApproveCore.approved.txt to include this code:

public class ParseArgumentException : System.Exception
    {
        public ParseArgumentException(string message, System.Exception ex) { }
    }

since you have added new public exception class. Just run Akka.API.Tests and copy text from .received.txt to approved.txt.

And I will try to fix the problem why our approval spec is failing with NRE instead of reporting the real problem.

[IgorFedchenko]

Ok, in Gitter we decided to use ArgumentException instead. So this is waiting for @to11mtm now.

P.S. I am fixing our approval specs failure reporting here: #4766

[IgorFedchenko]

Seems like only racy specs are failing here now...