Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the forced waiting on the underlying transport to start up #5440

Merged

Conversation

Aaronontheweb
Copy link
Member

Want to see what the impact of this is on the test suite.

@Aaronontheweb
Copy link
Member Author

Added this primarily to test whether or not this change or the .NET 6 threadpool changes were responsible for some of our racy test failures. Based on the test flip rate reports going back 30 days these look like .NET 6 threadpool issues.

Test Rate Failures for Akka.NET PR Pipeline: https://dev.azure.com/dotnet/Akka.NET/_test/analytics?definitionId=84&contextType=build

@Aaronontheweb
Copy link
Member Author

Added #5441 to this

Aaronontheweb and others added 5 commits December 20, 2021 09:09
…s_property_of_OneForOneStrategy` (akkadotnet#5442)

issue was that using `AutoReset` could cause a race where if the scheduler could reset the count in-flight and throw off the estimates used by the tests. Using a `ManualReset` avoids this issue.
* Make updates to `FishUntil`

Implement nitpicks from akkadotnet#5430

* Nitpick

* cleaned up `FishUntilMessage`

* removed `FluentAssertions` reference

* fixed bad `TestKit.ReceiveTests`
* Custom frame size computation support in Framing

* Speed up of framing spec
@Aaronontheweb Aaronontheweb marked this pull request as ready for review December 20, 2021 15:10
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) December 20, 2021 15:11
@Aaronontheweb Aaronontheweb merged commit a0f4705 into akkadotnet:dev Dec 20, 2021
@Aaronontheweb Aaronontheweb deleted the startup/remove-provider-hack branch January 12, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants