[Async TestKit] Convert Akka.Cluster.Tests to async - ClusterSpec #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Jun 7, 2022
src/core/Akka.Cluster/Cluster.cs
Outdated
| var completion = new TaskCompletionSource<NotUsed>(TaskCreationOptions.RunContinuationsAsynchronously); | ||
|
|
||
| var timeoutCts = CancellationTokenSource.CreateLinkedTokenSource(token); | ||
| timeoutCts.CancelAfter(Settings.SeedNodeTimeout); |
There was a problem hiding this comment.
Should be join-retry timeout
There was a problem hiding this comment.
akka.cluster.retry-unsuccessful-join-after?
…l-join-after`, defaulting to 10s if its null.
Closed
Aaronontheweb
approved these changes
Jun 7, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change how
Cluster.JoinAsync()andCluster.JoinSeedNodesAsync()work, does not rely onMemberRemovedanymore, work on a fixed timer instead, configurable via theakka.cluster.seed-node-timeoutHOCON settings.