Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ClusterLogSpec, EventFilter does not play nice with Within #6041

Merged
merged 2 commits into from Jul 13, 2022
Merged

Fix ClusterLogSpec, EventFilter does not play nice with Within #6041

merged 2 commits into from Jul 13, 2022

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Jul 13, 2022 •
edited

Changes

Use ExpectOneAsync with timeout support instead of using a Within block

Aaronontheweb
Aaronontheweb approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus merged commit 32040a3 into akkadotnet:dev Jul 13, 2022
@Arkatufus Arkatufus deleted the async_testkit/harden_ClusterLogSpec branch February 27, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkatufus @Aaronontheweb