Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Streams.Tests.Dsl.MergeHub_must_work_with_long_streams_when_buffer_size_is_1 #6054

Merged
merged 2 commits into from Jul 28, 2022
Merged

Fix Streams.Tests.Dsl.MergeHub_must_work_with_long_streams_when_buffer_size_is_1 #6054

merged 2 commits into from Jul 28, 2022

Conversation

Arkatufus
Copy link
Contributor

Fixes #6051

Changes

  • Removed the .Take() stage, suspected culprit.
  • Check each event manually instead of relying on ExpectNextNAsync

Aaronontheweb
Aaronontheweb approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit f571e26 into akkadotnet:dev Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-streams tests
Projects
None yet
Milestone
No milestone
2 participants
@Arkatufus @Aaronontheweb