Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled Directive.Resume to log the full Exception #6070

Merged

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Aug 23, 2022

Changes

Modified the default SupervisorStrategy to record the full Exception when a Warning is issued when a Directive.Resume is returned by the Decider when handling child actor failures. The only material impact of this is improved visibility into the stack trace and error details.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Modified the default `SupervisorStrategy` to record the full `Exception` when a `Warning` is issued when a `Directive.Resume` is returned by the `Decider` when handling child actor failures. The only material impact of this is improved visibility into the stack trace and error details.
@Aaronontheweb Aaronontheweb added akka-actor logging akka.net v1.4 Issues affecting Akka.NET v1.4 labels Aug 23, 2022
@Aaronontheweb Aaronontheweb added this to the 1.4.41 milestone Aug 23, 2022
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) August 23, 2022 15:47
@Aaronontheweb Aaronontheweb merged commit 3dff658 into akkadotnet:v1.4 Aug 23, 2022
@Aaronontheweb Aaronontheweb deleted the v1.4-log-exception-supervision branch August 23, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka.net v1.4 Issues affecting Akka.NET v1.4 akka-actor logging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants