Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend DistributedData Replicator settings with VerboseDebugLogging switch #6080

Merged
merged 5 commits into from Aug 30, 2022

Conversation

object
Copy link
Contributor

@object object commented Aug 29, 2022

Fixes #6074

Changes

This PR extends Akka.DistributedData.ReplicatorSettings with a switch VerboseDebugLogging. This switch is set to false by default to prevent excessive logging of gossip status.

NB! I was not sure of whether I had to update CoreAPISpec.ApproveDistributedData.XXX.verified.txt files. I updated them in a separate commit in case it's needed.

@object
Copy link
Contributor Author

object commented Aug 29, 2022

I see that there's a failing test in my PR. Will have to investigate what's failing.

@Aaronontheweb
Copy link
Member

@object
Copy link
Contributor Author

object commented Aug 30, 2022

@Aaronontheweb I've fixed API approval failures, it still fails but seems to be unrelated to my changes. Here are some of the errors:

2022-08-30T10:00:59.7043497Z D:\a\1\s\tools\incrementalist\incrementalist.exe "-b" "dev" "-s" "D:\a\1\s\src\Akka.sln" "-f" "D:\a\1\s\bin\incrementalist.txt" 
2022-08-30T10:01:18.0092979Z fail: Incrementalist[0]
2022-08-30T10:01:18.0095609Z       Issue during solution loading: Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace: Msbuild failed when processing the file 'D:\a\1\s\src\core\Akka.FSharp\Akka.FSharp.fsproj' with message: C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\Microsoft.FSharp.Targets: (317, 9): The specified task executable location "C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\fsc.exe" is invalid.
2022-08-30T10:01:18.0097718Z fail: Incrementalist[0]
2022-08-30T10:01:18.0100193Z       Issue during solution loading: Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace: Msbuild failed when processing the file 'D:\a\1\s\src\core\Akka.FSharp\Akka.FSharp.fsproj' with message: C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\Microsoft.FSharp.Targets: (317, 9): The specified task executable location "C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\fsc.exe" is invalid.
2022-08-30T10:01:18.0102080Z fail: Incrementalist[0]
2022-08-30T10:01:18.0105559Z       Issue during solution loading: Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace: Msbuild failed when processing the file 'D:\a\1\s\src\core\Akka.FSharp\Akka.FSharp.fsproj' with message: C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\Microsoft.FSharp.Targets: (317, 9): The specified task executable location "C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\fsc.exe" is invalid.
2022-08-30T10:01:18.0107431Z fail: Incrementalist[0]
2022-08-30T10:01:18.0109178Z       Issue during solution loading: Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace: Msbuild failed when processing the file 'D:\a\1\s\src\core\Akka.FSharp\Akka.FSharp.fsproj' with message: C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\Microsoft.FSharp.Targets: (317, 9): The specified task executable location "C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\fsc.exe" is invalid.
2022-08-30T10:01:18.1295689Z fail: Incrementalist[0]
2022-08-30T10:01:18.1298146Z       Issue during solution loading: Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace: Msbuild failed when processing the file 'D:\a\1\s\src\core\Akka.FSharp.Tests\Akka.FSharp.Tests.fsproj' with message: C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\Microsoft.FSharp.Targets: (317, 9): The specified task executable location "C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\FSharp\fsc.exe" is invalid.

@Aaronontheweb
Copy link
Member

Ah, it was still the approval tests - there are three files that all have to be checked in: .NET Framework, .NET Core 3.1, and .NET 6.

I also added back an old constructor in order to ensure binary compatibility.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) August 30, 2022 13:11
@Aaronontheweb
Copy link
Member

Had once test miss its within block by 2 milliseconds - not a big deal. Happens with those timing specs. This looks good - going to merge it in.

@Aaronontheweb Aaronontheweb merged commit e3511dc into akkadotnet:dev Aug 30, 2022
@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Aug 31, 2022
Aaronontheweb pushed a commit that referenced this pull request Aug 31, 2022
…oseDebugLogging switch (#6084)

* Cherry-picked from e3511dc

* Fix API verify list

Co-authored-by: Vagif Abilov <vagif.abilov@nrk.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Received gossip status" message is always logged by DistributedData
2 participants