removed boxing allocations inside FSM.State.Equals
#6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `object.Equals` call here generated hundreds of mb in boxing allocations inside RemotePingPong - using the `EqualityComparer<TState>.Default.Equals` eliminates them.
Benchmarks
|
| Method | MsgCount | Mean | Error | StdDev | Ratio | RatioSD | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|---|
| BenchmarkFsm | 1000000 | 741.2 ms | 13.85 ms | 12.95 ms | 1.55 | 0.05 | 35000.0000 | 4000.0000 | 1000.0000 | 150 MB |
| BenchmarkUntyped | 1000000 | 477.1 ms | 9.52 ms | 11.33 ms | 1.00 | 0.00 | 12000.0000 | 4000.0000 | 1000.0000 | 56 MB |
This PR
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19044.2130 (21H2)
AMD Ryzen 7 1700, 1 CPU, 16 logical and 8 physical cores
.NET SDK=6.0.201
[Host] : .NET 6.0.3 (6.0.322.12309), X64 RyuJIT
DefaultJob : .NET 6.0.3 (6.0.322.12309), X64 RyuJIT
| Method | MsgCount | Mean | Error | StdDev | Ratio | RatioSD | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|---|
| BenchmarkFsm | 1000000 | 704.1 ms | 12.67 ms | 12.44 ms | 1.43 | 0.05 | 24000.0000 | 4000.0000 | 1000.0000 | 104 MB |
| BenchmarkUntyped | 1000000 | 494.4 ms | 9.63 ms | 13.50 ms | 1.00 | 0.00 | 13000.0000 | 3000.0000 | 1000.0000 | 56 MB |
Memory reduction of ~50mb and a throughput improvement of ~8% or so.
Arkatufus
pushed a commit
to Arkatufus/akka.net
that referenced
this pull request
Oct 17, 2022
The `object.Equals` call here generated hundreds of mb in boxing allocations inside RemotePingPong - using the `EqualityComparer<TState>.Default.Equals` eliminates them. (cherry picked from commit 183ec5a)
Aaronontheweb
added a commit
that referenced
this pull request
Oct 17, 2022
The `object.Equals` call here generated hundreds of mb in boxing allocations inside RemotePingPong - using the `EqualityComparer<TState>.Default.Equals` eliminates them. (cherry picked from commit 183ec5a) Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
object.Equalscall here generated hundreds of mb in boxing allocations inside RemotePingPong - using theEqualityComparer<TState>.Default.Equalseliminates them.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksUsed Rider's Dynamic Program Analysis to verify that the allocations were removed.