Make transport adapter messages public #6250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Nov 14, 2022
| @@ -580,6 +580,58 @@ namespace Akka.Remote.Transport | |||
| public FailureInjectorProvider() { } | |||
| public Akka.Remote.Transport.Transport Create(Akka.Remote.Transport.Transport wrappedTransport, Akka.Actor.ExtendedActorSystem system) { } | |||
| } | |||
| public class FailureInjectorTransportAdapter : Akka.Remote.Transport.AbstractTransportAdapter, Akka.Remote.Transport.IAssociationEventListener | |||
There was a problem hiding this comment.
LGTM - this is sufficiently obscure that it's not going to regularly pop-up in end-user code, but still accessible to an extent that tooling like our planned "failure injection" feature for Petabridge.Cmd can still work.
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
Feb 28, 2023
* Make transport adapter messages public so it can be used in Petabridge.Cmd for testing network disruptions * Update API Verify list * Fixing DocFx complaints Co-authored-by: Aaron Stannard <aaron@petabridge.com> (cherry picked from commit e94913c)
Aaronontheweb
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Make transport adapter messages public (#6250) * Make transport adapter messages public so it can be used in Petabridge.Cmd for testing network disruptions * Update API Verify list * Fixing DocFx complaints Co-authored-by: Aaron Stannard <aaron@petabridge.com> (cherry picked from commit e94913c) * Update API Verify list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for https://github.com/petabridge/petabridge.cmd/pull/587
Changes
Make transport adapter messages public so it can be used in Petabridge.Cmd for testing network disruptions