Add compression option for NewtonSoftJsonSerializer #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arkatufus I know you shared data with me on Slack, but can you include any benchmark data for this? |
Aaronontheweb
requested changes
Jan 11, 2023
| @@ -4789,6 +4789,7 @@ namespace Akka.Serialization | |||
| public NewtonSoftJsonSerializer(Akka.Actor.ExtendedActorSystem system) { } | |||
| public NewtonSoftJsonSerializer(Akka.Actor.ExtendedActorSystem system, Akka.Configuration.Config config) { } | |||
| public NewtonSoftJsonSerializer(Akka.Actor.ExtendedActorSystem system, Akka.Serialization.NewtonSoftJsonSerializerSettings settings) { } | |||
| public bool Compressed { get; } | |||
| # JSON string using GZip. | ||
| # Useful to avoid network congestion when your serialized | ||
| # data starts to grow to the megabyte size | ||
| use-compression = false |
There was a problem hiding this comment.
LGTM - fully wire compatible
Aaronontheweb
approved these changes
Jan 11, 2023
Aaronontheweb
added
akka.net v1.4
|
@Arkatufus needs to be ported to v1.5 |
Aaronontheweb
added a commit
that referenced
this pull request
Jan 16, 2023
This reverts commit d7daf56.
Aaronontheweb
added a commit
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
use-compressionto NewtonSoftJsonSerializerSystem.IO.Compression.GZip