Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DeprecatedSchedulerExtensions #6438

Merged

Conversation

Arkatufus
Copy link
Contributor

Changes

Remove deprecated DeprecatedSchedulerExtensions

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs API approval

@@ -76,8 +76,7 @@ public Cancelable(IActionScheduler scheduler)
//Intentionally left blank
}

[Obsolete("Only to be used from DeprecatedSchedulerExtensions. [1.0.0]")] //TODO: Remove this line and make it private when DeprecatedSchedulerExtensions is removed
internal Cancelable(IActionScheduler scheduler, CancellationTokenSource source)
private Cancelable(IActionScheduler scheduler, CancellationTokenSource source)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 05cfaca into akkadotnet:dev Feb 24, 2023
@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants