Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete methods from Akka.DistributedData #6443

Merged
merged 1 commit into from Feb 27, 2023

Conversation

Arkatufus
Copy link
Contributor

No description provided.

@@ -166,105 +166,6 @@ public static ReplicatorSettings Create(Config config)
/// </summary>
public bool VerboseDebugLogging { get; }

[Obsolete]
public ReplicatorSettings(string role,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete since v1.4.22 (2 years)

{
}

[Obsolete]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete since v1.4.22 (2 years)

@Aaronontheweb
Copy link
Member

This is probably fine - I doubt many people manually spin up ReplicatorSettings without parsing it from the ActorSystem first anyway.

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) February 27, 2023 15:50
@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Feb 27, 2023
@Aaronontheweb Aaronontheweb merged commit f4078cc into akkadotnet:dev Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants