Remove obsolete methods and properties from Akka.Cluster #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Feb 27, 2023
| /// Obsolete. Use <see cref="P:Cluster.DowningProvider.DownRemovalMargin"/>. | ||
| /// </summary> | ||
| [Obsolete("Use Cluster.DowningProvider.DownRemovalMargin [1.1.2]")] | ||
| public TimeSpan DownRemovalMargin { get; } |
There was a problem hiding this comment.
Obsolete since v1.1.2
Arkatufus
commented
Feb 27, 2023
| /// <param name="allowLocalRoutees">N/A</param> | ||
| /// <param name="routeesPaths">N/A</param> | ||
| [Obsolete("This method is deprecated [1.1.0]")] | ||
| public ClusterRouterGroupSettings(int totalInstances, bool allowLocalRoutees, IEnumerable<string> routeesPaths) |
There was a problem hiding this comment.
Obsolete since v1.1.0
Arkatufus
commented
Feb 27, 2023
| /// <param name="useRole">N/A</param> | ||
| /// <param name="routeesPaths">N/A</param> | ||
| [Obsolete("This method is deprecated [1.1.0]")] | ||
| public ClusterRouterGroupSettings(int totalInstances, bool allowLocalRoutees, string useRole, ImmutableHashSet<string> routeesPaths) |
There was a problem hiding this comment.
Obsolete since v1.1.0
Arkatufus
commented
Feb 27, 2023
| /// <param name="allowLocalRoutees">N/A</param> | ||
| /// <param name="maxInstancesPerNode">N/A</param> | ||
| [Obsolete("This method is deprecated [1.1.0]")] | ||
| public ClusterRouterPoolSettings(int totalInstances, bool allowLocalRoutees, int maxInstancesPerNode) |
There was a problem hiding this comment.
Obsolete since 1.1.0
Arkatufus
commented
Feb 27, 2023
| /// <param name="useRole">N/A</param> | ||
| /// <param name="maxInstancesPerNode">N/A</param> | ||
| [Obsolete("This method is deprecated [1.1.0]")] | ||
| public ClusterRouterPoolSettings(int totalInstances, bool allowLocalRoutees, string useRole, int maxInstancesPerNode) |
There was a problem hiding this comment.
Obsolete since v1.1.0
Arkatufus
commented
Feb 27, 2023
| @@ -166,18 +166,6 @@ public KeepOldestSettings(bool downIfAlone, string role) | |||
|
|
|||
| public sealed class LeaseMajoritySettings | |||
| { | |||
| [Obsolete] | |||
| public LeaseMajoritySettings(string leaseImplementation, TimeSpan acquireLeaseDelayForMinority, string role) | |||
There was a problem hiding this comment.
Obsolete since v1.4.22
Arkatufus
commented
Feb 27, 2023
| } | ||
|
|
||
| [Obsolete] | ||
| public LeaseMajoritySettings(string leaseImplementation, TimeSpan acquireLeaseDelayForMinority, string role, string leaseName) |
There was a problem hiding this comment.
Obsolete since v1.4.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.