Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete methods from Akka.Persistence #6447

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Remove obsolete methods from Akka.Persistence #6447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistence.Core.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,6 @@ namespace Akka.Persistence
}
public sealed class WriteMessagesFailed : Akka.Actor.INoSerializationVerificationNeeded, Akka.Persistence.IJournalMessage, Akka.Persistence.IJournalResponse, Akka.Persistence.IPersistenceMessage, System.IEquatable<Akka.Persistence.WriteMessagesFailed>
{
[System.ObsoleteAttribute("Deprecated since Akka 1.4.11, use the overloaded one which accepts the number of " +
"failed atomic writes instead.")]
public WriteMessagesFailed(System.Exception cause) { }
public WriteMessagesFailed(System.Exception cause, int writeCount) { }
public System.Exception Cause { get; }
public int WriteCount { get; }
Expand Down
3 changes: 0 additions & 3 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistence.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,6 @@ namespace Akka.Persistence
}
public sealed class WriteMessagesFailed : Akka.Actor.INoSerializationVerificationNeeded, Akka.Persistence.IJournalMessage, Akka.Persistence.IJournalResponse, Akka.Persistence.IPersistenceMessage, System.IEquatable<Akka.Persistence.WriteMessagesFailed>
{
[System.ObsoleteAttribute("Deprecated since Akka 1.4.11, use the overloaded one which accepts the number of " +
"failed atomic writes instead.")]
public WriteMessagesFailed(System.Exception cause) { }
public WriteMessagesFailed(System.Exception cause, int writeCount) { }
public System.Exception Cause { get; }
public int WriteCount { get; }
Expand Down
3 changes: 0 additions & 3 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistence.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,6 @@ namespace Akka.Persistence
}
public sealed class WriteMessagesFailed : Akka.Actor.INoSerializationVerificationNeeded, Akka.Persistence.IJournalMessage, Akka.Persistence.IJournalResponse, Akka.Persistence.IPersistenceMessage, System.IEquatable<Akka.Persistence.WriteMessagesFailed>
{
[System.ObsoleteAttribute("Deprecated since Akka 1.4.11, use the overloaded one which accepts the number of " +
"failed atomic writes instead.")]
public WriteMessagesFailed(System.Exception cause) { }
public WriteMessagesFailed(System.Exception cause, int writeCount) { }
public System.Exception Cause { get; }
public int WriteCount { get; }
Expand Down
13 changes: 0 additions & 13 deletions src/core/Akka.Persistence/JournalProtocol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,19 +280,6 @@ public sealed class WriteMessagesSuccessful : IJournalResponse
[Serializable]
public sealed class WriteMessagesFailed : IJournalResponse, IEquatable<WriteMessagesFailed>
{
/// <summary>
/// Initializes a new instance of the <see cref="WriteMessagesFailed"/> class.
/// </summary>
/// <param name="cause">The cause of the failed <see cref="WriteMessages"/> request.</param>
/// <exception cref="ArgumentNullException">
/// This exception is thrown when the specified <paramref name="cause"/> is undefined.
/// </exception>
[Obsolete("Deprecated since Akka 1.4.11, use the overloaded one which accepts the number of failed atomic writes instead.")]
public WriteMessagesFailed(Exception cause)
{
Cause = cause ?? throw new ArgumentNullException(nameof(cause), "WriteMessagesFailed cause exception cannot be null");
}

/// <summary>
/// Initializes a new instance of the <see cref="WriteMessagesFailed"/> class.
/// </summary>
Expand Down