Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete methods from Akka.Event and Akka.Dispatch #6457

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Remove obsolete methods from Akka.Event and Akka.Dispatch #6457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Core.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2817,9 +2817,6 @@ namespace Akka.Dispatch.MessageQueues
}
public class UnboundedPriorityMessageQueue : Akka.Dispatch.MessageQueues.BlockingMessageQueue, Akka.Dispatch.IDequeBasedMessageQueueSemantics, Akka.Dispatch.ISemantics, Akka.Dispatch.IUnboundedDequeBasedMessageQueueSemantics, Akka.Dispatch.IUnboundedMessageQueueSemantics
{
[System.ObsoleteAttribute("Use UnboundedPriorityMessageQueue(Func<object, int> priorityGenerator, int initia" +
"lCapacity) instead. [1.1.3]")]
public UnboundedPriorityMessageQueue(int initialCapacity) { }
public UnboundedPriorityMessageQueue(System.Func<object, int> priorityGenerator, int initialCapacity) { }
protected override int LockedCount { get; }
public void EnqueueFirst(Akka.Actor.Envelope envelope) { }
Expand Down Expand Up @@ -3063,8 +3060,6 @@ namespace Akka.Event
public class EventStream : Akka.Event.LoggingBus
{
public EventStream(bool debug) { }
[System.ObsoleteAttribute("Should be removed in 1.5")]
public bool InitUnsubscriber(Akka.Actor.IActorRef unsubscriber, Akka.Actor.ActorSystem system) { }
public void StartUnsubscriber(Akka.Actor.Internal.ActorSystemImpl system) { }
public override bool Subscribe(Akka.Actor.IActorRef subscriber, System.Type channel) { }
public override bool Unsubscribe(Akka.Actor.IActorRef subscriber, System.Type channel) { }
Expand Down
5 changes: 0 additions & 5 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2822,9 +2822,6 @@ namespace Akka.Dispatch.MessageQueues
}
public class UnboundedPriorityMessageQueue : Akka.Dispatch.MessageQueues.BlockingMessageQueue, Akka.Dispatch.IDequeBasedMessageQueueSemantics, Akka.Dispatch.ISemantics, Akka.Dispatch.IUnboundedDequeBasedMessageQueueSemantics, Akka.Dispatch.IUnboundedMessageQueueSemantics
{
[System.ObsoleteAttribute("Use UnboundedPriorityMessageQueue(Func<object, int> priorityGenerator, int initia" +
"lCapacity) instead. [1.1.3]")]
public UnboundedPriorityMessageQueue(int initialCapacity) { }
public UnboundedPriorityMessageQueue(System.Func<object, int> priorityGenerator, int initialCapacity) { }
protected override int LockedCount { get; }
public void EnqueueFirst(Akka.Actor.Envelope envelope) { }
Expand Down Expand Up @@ -3068,8 +3065,6 @@ namespace Akka.Event
public class EventStream : Akka.Event.LoggingBus
{
public EventStream(bool debug) { }
[System.ObsoleteAttribute("Should be removed in 1.5")]
public bool InitUnsubscriber(Akka.Actor.IActorRef unsubscriber, Akka.Actor.ActorSystem system) { }
public void StartUnsubscriber(Akka.Actor.Internal.ActorSystemImpl system) { }
public override bool Subscribe(Akka.Actor.IActorRef subscriber, System.Type channel) { }
public override bool Unsubscribe(Akka.Actor.IActorRef subscriber, System.Type channel) { }
Expand Down
5 changes: 0 additions & 5 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2817,9 +2817,6 @@ namespace Akka.Dispatch.MessageQueues
}
public class UnboundedPriorityMessageQueue : Akka.Dispatch.MessageQueues.BlockingMessageQueue, Akka.Dispatch.IDequeBasedMessageQueueSemantics, Akka.Dispatch.ISemantics, Akka.Dispatch.IUnboundedDequeBasedMessageQueueSemantics, Akka.Dispatch.IUnboundedMessageQueueSemantics
{
[System.ObsoleteAttribute("Use UnboundedPriorityMessageQueue(Func<object, int> priorityGenerator, int initia" +
"lCapacity) instead. [1.1.3]")]
public UnboundedPriorityMessageQueue(int initialCapacity) { }
public UnboundedPriorityMessageQueue(System.Func<object, int> priorityGenerator, int initialCapacity) { }
protected override int LockedCount { get; }
public void EnqueueFirst(Akka.Actor.Envelope envelope) { }
Expand Down Expand Up @@ -3063,8 +3060,6 @@ namespace Akka.Event
public class EventStream : Akka.Event.LoggingBus
{
public EventStream(bool debug) { }
[System.ObsoleteAttribute("Should be removed in 1.5")]
public bool InitUnsubscriber(Akka.Actor.IActorRef unsubscriber, Akka.Actor.ActorSystem system) { }
public void StartUnsubscriber(Akka.Actor.Internal.ActorSystemImpl system) { }
public override bool Subscribe(Akka.Actor.IActorRef subscriber, System.Type channel) { }
public override bool Unsubscribe(Akka.Actor.IActorRef subscriber, System.Type channel) { }
Expand Down
10 changes: 0 additions & 10 deletions src/core/Akka/Dispatch/MessageQueues/UnboundedPriorityMessageQueue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,6 @@ public class UnboundedPriorityMessageQueue : BlockingMessageQueue, IUnboundedDeq
// doesn't need to be threadsafe - only called from within actor
private readonly Stack<Envelope> _prependBuffer = new Stack<Envelope>();

/// <summary>
/// DEPRECATED. Use <see cref="UnboundedPriorityMessageQueue(Func{object,int}, int)"/> instead.
/// </summary>
/// <param name="initialCapacity">The initial capacity of the priority queue.</param>
[Obsolete("Use UnboundedPriorityMessageQueue(Func<object, int> priorityGenerator, int initialCapacity) instead. [1.1.3]")]
public UnboundedPriorityMessageQueue(int initialCapacity) : this(ListPriorityQueue.DefaultPriorityCalculator, initialCapacity)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete since v1.1.3 (6 years)

{

}

/// <summary>
/// Creates a new unbounded priority message queue.
/// </summary>
Expand Down
7 changes: 0 additions & 7 deletions src/core/Akka/Event/EventStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,6 @@ public void StartUnsubscriber(ActorSystemImpl system)
}
}

[Obsolete("Should be removed in 1.5")]
public bool InitUnsubscriber(IActorRef unsubscriber, ActorSystem system)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete since v1.4.35 (last year)

{
StartUnsubscriber((ActorSystemImpl)system);
return true;
}

private void RegisterWithUnsubscriber(IActorRef subscriber)
{
if (_unsubscriber.Value.IsNobody())
Expand Down