Akka.Actor: tuck all scheduled Tell messages into IScheduledMsg envelope
#6461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Motivation for this is primarily telemetry - making it easier to determine what is and is not a scheduled message. I'd probably rather make this a 1.5.1 thing though since I think I need more time to let it cook... |
|
@Arkatufus if the tests look good, next thing we need to run are benchmarks - InMemoryPingPong and RemotePingPong, since this touches the hotpath in the |
RemotePingPong BenchmarkValues are a median of 5 runs New Code
Dev Branch
|
Akka.Benchmark PingPongBenchmarks ResultDev Branch
New Code
|
|
No negative performance impact - that's good. |
Aaronontheweb
commented
Aug 25, 2023
| namespace Akka.Actor.Scheduler | ||
| { | ||
| [Akka.Annotations.InternalApiAttribute()] | ||
| public interface IScheduledTellMsg : Akka.Actor.INoSerializationVerificationNeeded, Akka.Actor.IWrappedMessage { } |
There was a problem hiding this comment.
Fixing up some bad test changes - looks fine
src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds some overhead to actor message processing (minor), but makes it possible for us to detect scheduled messages and filter them out from telemetry. Doesn't need to ship as part of v1.5 - can be done after.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):