Log send time and sqNbr in verbose cluster heartbeat messages #6496. #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F0b0s
commented
Mar 23, 2023
F0b0s
commented
Mar 23, 2023
| @@ -248,7 +247,8 @@ private void CheckTickInterval() | |||
| "Previous heartbeat was sent [{1}] ms ago, expected interval is [{2}] ms. This may cause failure detection " + | |||
| "to mark members as unreachable. The reason can be thread starvation, e.g. by running blocking tasks on the " + | |||
| "default dispatcher, CPU overload, or GC.", | |||
| _cluster.SelfAddress, (now - _tickTimestamp).TotalMilliseconds, _cluster.Settings.HeartbeatInterval.TotalMilliseconds); | |||
| _cluster.SelfAddress, (now - _tickTimestamp).TotalMilliseconds.ToString(CultureInfo.InvariantCulture), | |||
There was a problem hiding this comment.
Usage of CultureInfo.InvariantCulture here may be breaking changes, because without ToString logger calls object.ToString() which should use current culture.
Not sure do we need to use InvariantCulture here.
There was a problem hiding this comment.
InvariantCulture is the right call - won't be a breaking change for anyone (we don't consider updates to the content of log messages to be breaking changes.)
Aaronontheweb
requested changes
Mar 23, 2023
| @@ -248,7 +247,8 @@ private void CheckTickInterval() | |||
| "Previous heartbeat was sent [{1}] ms ago, expected interval is [{2}] ms. This may cause failure detection " + | |||
| "to mark members as unreachable. The reason can be thread starvation, e.g. by running blocking tasks on the " + | |||
| "default dispatcher, CPU overload, or GC.", | |||
| _cluster.SelfAddress, (now - _tickTimestamp).TotalMilliseconds, _cluster.Settings.HeartbeatInterval.TotalMilliseconds); | |||
| _cluster.SelfAddress, (now - _tickTimestamp).TotalMilliseconds.ToString(CultureInfo.InvariantCulture), | |||
There was a problem hiding this comment.
InvariantCulture is the right call - won't be a breaking change for anyone (we don't consider updates to the content of log messages to be breaking changes.)
Aaronontheweb
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6496
Changes
Log send time and sqNbr in verbose cluster heartbeat messages
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):