Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS0618] InternalFlowOperations - Warning Disable #6674

Merged
merged 8 commits into from Jan 18, 2024

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Apr 25, 2023

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Copy link
Contributor Author

@eaba eaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use GraphStage instead because IStage it is Obsolete however IStage it is an Interface

Func<IStage<TIn, TOut>> stageFactory)
#pragma warning restore CS0618 // Type or member is obsolete
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IStage Obsolete

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't understand - why is disabling the warning the right fix here versus marking this method as obsolete itself?

Copy link
Contributor Author

@eaba eaba May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Obsolete("Please use GraphStage instead. [1.1.0]")]
public interface IStage<in TIn, out TOut> { }

IStage<TIn, TOut> it is an Interface

@HamzaAmjad-RG
Copy link
Contributor

Hey, Can you help me with the PR, I changed a word in Documentation here: https://getakka.net/articles/actors/receive-actor-api.html and two DocFx tests are failing.

@Aaronontheweb
Copy link
Member

Hey, Can you help me with the PR, I changed a word in Documentation here: https://getakka.net/articles/actors/receive-actor-api.html and two DocFx tests are failing.

Which PR?

@Aaronontheweb Aaronontheweb merged commit 284d33a into akkadotnet:dev Jan 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants