DistributedPubSub: make query to count local subscribers for topic public #6856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blic close akkadotnet#3663 - between this and `Topic`s all local data should be queryable for distributed pub-sub
Aaronontheweb
commented
Jul 27, 2023
| /// </summary> | ||
| internal sealed class CountSubscribers | ||
| public sealed class CountSubscribers |
There was a problem hiding this comment.
Just made this internal class public - left it inside the .Internal namespace though (which I think this fine - it's public but we reserve the right to change it, per our API guidelines: https://getakka.net/community/contributing/api-changes-compatibility.html#akkanet-api-versioning-policy )
There was a problem hiding this comment.
Might want to decorate this class with [ApiMayChange] attribute for documentation purposes
Arkatufus
requested changes
Jul 27, 2023
| /// </summary> | ||
| internal sealed class CountSubscribers | ||
| public sealed class CountSubscribers |
There was a problem hiding this comment.
Might want to decorate this class with [ApiMayChange] attribute for documentation purposes
Arkatufus
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #3663 - between this and
Topics all local data should be queryable for distributed pub-subChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):