Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PeriodicTimer scheduler deadlock during start #6946

Merged
merged 2 commits into from Oct 5, 2023
Merged

Fix PeriodicTimer scheduler deadlock during start #6946

merged 2 commits into from Oct 5, 2023

Conversation

Arkatufus
Copy link
Contributor

Scheduler PeriodicTimer async start can deadlock if disposed immediately

Changes

  • Change detached task execution to use Task.Run()

Aaronontheweb
Aaronontheweb approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb added this to the 1.5.14 milestone Oct 5, 2023
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) October 5, 2023 12:42
@Aaronontheweb Aaronontheweb merged commit 6f527f9 into akkadotnet:dev Oct 5, 2023
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-actor confirmed bug
Projects
None yet
Milestone
1.5.14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkatufus @Aaronontheweb