#6816 Akka.DistributedData.LightningDb: move durable folder creation outside of actor constructor #6983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created unit tests to support new changes
YariSPB
commented
Nov 5, 2023
| public void Lmdb_logs_meaningful_error_for_invalid_dir_path() | ||
| { | ||
| // Try to create a directory with a path exceeding allowed length | ||
| string invalidName = new string('A', 247); |
There was a problem hiding this comment.
This test fails on Azure Pipeline because cloud's allowed directory path length exceeds 248 characters, and a folder is created, which shouldn't happen. Probably, it is better to remove this unit test completely because it relies on environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6816 Akka.DistributedData.LightningDb: move durable folder creation outside of actor constructor in order to preserve stack trace / provide clearer error messages
Fixes #
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.