Akka.Actor: make Context.Watch and Context.Unwatch enforce #nullable
#7155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Apr 10, 2024
| @@ -4,13 +4,12 @@ | |||
| // Copyright (C) 2013-2023 .NET Foundation <https://github.com/akkadotnet/akka.net> | |||
| // </copyright> | |||
| //----------------------------------------------------------------------- | |||
|
|
|||
| #nullable enable | |||
There was a problem hiding this comment.
Been seeing some NRE's coming from the Unwatch handlers inside this class as part of the ActorLeakSpec - decided to enable nullable here to see what all is going on.
| @@ -25,6 +24,7 @@ partial class ActorCell | |||
| /// <returns>TBD</returns> | |||
| public IActorRef Watch(IActorRef subject) | |||
| { | |||
| if(subject is null) throw new ArgumentNullException(nameof(subject), "subject must not be null"); | |||
There was a problem hiding this comment.
This is illegal. Should throw.
| @@ -46,6 +46,7 @@ public IActorRef Watch(IActorRef subject) | |||
| /// <returns>TBD</returns> | |||
| public IActorRef WatchWith(IActorRef subject, object message) | |||
| { | |||
| if(subject is null) throw new ArgumentNullException(nameof(subject), "subject must not be null"); | |||
| @@ -69,6 +70,8 @@ public IActorRef WatchWith(IActorRef subject, object message) | |||
| /// <returns>TBD</returns> | |||
| public IActorRef Unwatch(IActorRef subject) | |||
| { | |||
| if(subject is null) throw new ArgumentNullException(nameof(subject), "subject must not be null"); | |||
Aaronontheweb
commented
Apr 11, 2024
|
|
||
| // Bugfix: need to filter out the AssociationTermination messages for remote@127.0.0.1:2553 from the quarantine | ||
| // case, otherwise those logs might get picked up during the next text case | ||
| Sys.EventStream.Publish(new Mute(new WarningFilter( new ContainsString("Association with remote system akka.trttl.tcp://remote@127.0.0.1:2553 has failed")))); |
There was a problem hiding this comment.
Ugh, we're going to have to do this after every test case - Akka.Remote's retry / reconnect bits are what's aggravating this.
Aaronontheweb
changed the title
ActorsLeakSpecContext.Watch and Context.Unwatch enforce #nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
One of the raciest tests in the suite - looks like there's some residual slopiness with how we use the
EventFilterplus one potential race condition withContext.Unwatchthat need to be fixed.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):