Akka.Router: automatically unpack IScheduledTellMsg when being handled through a router
#7249
+76
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jun 12, 2024
| { | ||
| var allRoutees = await router.Ask<Routees>(GetRoutees.Instance); | ||
| allRoutees.Members.Count().ShouldBeGreaterThan(0); | ||
| }); |
There was a problem hiding this comment.
You can't target a /temp actor via ActorSelection, so I had to go through some extra steps in order to get the FutureActorRef added to the BroadcastGroup router here.
| Router.Route(envelope.Message, envelope.Sender); | ||
| { | ||
| // Bugfix: https://github.com/akkadotnet/akka.net/issues/7247 | ||
| if(envelope.Message is IScheduledTellMsg scheduledTellMsg) |
There was a problem hiding this comment.
This is the real fix here - and I describe the root of problems here on the issue itself #7247 (comment)
There was a problem hiding this comment.
Technically this change means that certain messages will now show up in Phobos traces if they're sent through a router via the scheduler. I am fine with that.
Aaronontheweb
changed the title
IScheduledTellMsg when being handled through a router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Working on reproducing #7247
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
IScheduledTellMsgresults in serialization error #7247