Supervisor strategy bad timeouts #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2015 16:12
In chaining to other constructors, the constructors for the `AllForOne` and `OneForOne` strategies pull timeouts from `TimeSpan`s using the `Milliseconds` property. This is not the correct behavior for `TimeSpan` values greater than or equal to 1 second as it provides only the milliseconds portion of the timespan. Instead, use the `TotalMilliseconds` property and cast it to an `int`.
neoeinstein
force-pushed
the
supervisor-strategy-bad-timeouts
branch
from
5e4288a
to
0931aec
Compare
Aaronontheweb
added a commit
that referenced
this pull request
May 18, 2015
…outs Supervisor strategy bad timeouts
This was referenced Jun 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In chaining to other constructors, the constructors for the
AllForOneandOneForOnestrategies pull timeouts fromTimeSpans using theMillisecondsproperty. This is not the correct behavior forTimeSpanvalues greater than or equal to 1 second as it provides only the milliseconds portion of the timespan. Instead, use theTotalMillisecondsproperty and cast it to anint.