Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert null to NoSender. #993

Merged
merged 1 commit into from May 20, 2015

Conversation

Projects
None yet
2 participants
@rogeralsing
Copy link
Contributor

commented May 20, 2015

This PR makes it possible to explicitly pass null as sender to Tell as it is a fairly common mistake and we have no real reason to throw on it.

This PR also fixes some context leakage in the testkit

@@ -110,6 +110,12 @@ private TestKitBase(ITestKitAssertions assertions, ActorSystem system, Config co
{
InternalCurrentActorCellKeeper.Current = (ActorCell)((ActorRefWithCell)testActor).Underlying;
}
else if(!(this is TestProbe))

This comment has been minimized.

Copy link
@rogeralsing

rogeralsing May 20, 2015

Author Contributor

This is obviously ugly in every possible way. but the testkit currently requires two different behaviors based on type.
(it could be extracted to a virt method, but then again, virt methods from ctors and all that.)

This comment has been minimized.

Copy link
@Aaronontheweb

Aaronontheweb May 20, 2015

Member

Could you put a //TODO: on this line, letting someone in the future know why it's there?

This comment has been minimized.

Copy link
@rogeralsing

rogeralsing May 20, 2015

Author Contributor

there is a //HACK: on the line below already :)

Aaronontheweb added a commit that referenced this pull request May 20, 2015

@Aaronontheweb Aaronontheweb merged commit 452dde1 into akkadotnet:dev May 20, 2015

1 check passed

continuous-integration/teamcity Finished TeamCity Build Akka.NET :: Akka.NET PR Build : Tests passed: 1025, ignored: 21
Details

@rogeralsing rogeralsing deleted the rogeralsing:null-means-no branch Jun 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.