Convert null to NoSender. #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,6 +110,12 @@ private TestKitBase(ITestKitAssertions assertions, ActorSystem system, Config co | |||
| { | |||
| InternalCurrentActorCellKeeper.Current = (ActorCell)((ActorRefWithCell)testActor).Underlying; | |||
| } | |||
| else if(!(this is TestProbe)) | |||
There was a problem hiding this comment.
This is obviously ugly in every possible way. but the testkit currently requires two different behaviors based on type.
(it could be extracted to a virt method, but then again, virt methods from ctors and all that.)
There was a problem hiding this comment.
Could you put a //TODO: on this line, letting someone in the future know why it's there?
There was a problem hiding this comment.
there is a //HACK: on the line below already :)
Aaronontheweb
added a commit
that referenced
this pull request
May 20, 2015
Convert null to NoSender.
This was referenced Jun 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to explicitly pass null as
sendertoTellas it is a fairly common mistake and we have no real reason to throw on it.This PR also fixes some context leakage in the testkit