Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka.Configuration.Hocon backward compatibility: config.GetStringList should return empty list when not found #174

Closed
IgorFedchenko opened this issue Jan 16, 2020 · 1 comment · Fixed by #178
Labels
Milestone

Comments

@IgorFedchenko
Copy link
Contributor

config.GetStringList("not_existing_key") is throwing exception now. We have an overload to specify fallback default value, but Akka.Configuration.Hocon seem to be returning empty list when path is not found.

Also need to verify the same behavior for another config getters.

@IgorFedchenko
Copy link
Contributor Author

Turned out that all list getters line config.GetIntList and others were throwing NullReferenceException in Akka.Configiration.Hocon, and now it will throw more valid HoconValueException with error that path does not exist.
But for config.GetStringList there was a special case, and empty list was returning. Not sure why it is so, but updated HOCON implementation to do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants