Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gloo API provider if no domains declared #88

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

dotxlem
Copy link
Collaborator

@dotxlem dotxlem commented Sep 16, 2022

Gloo API provider panicked if no domain name was defined. Now returns a .local domain, which must be specified as the Host in HTTP requests. eg curl -H "Host: mysvc.myproj.local" http://<ip>

Also moves the Gloo Gateway installation to the cast step so that the CRDs will be available to Terraform.

needed on cast so that CRDs will be available to terraform
@dotxlem dotxlem marked this pull request as ready for review September 16, 2022 18:08
@dotxlem dotxlem merged commit 5319886 into akkoro:mainline Sep 16, 2022
@dotxlem dotxlem deleted the fix-gloo-no-domains branch September 16, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant