Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(messaging): Simplify protocol map definitions with function types #21

Merged
merged 5 commits into from
Mar 17, 2023
Merged

feat(messaging): Simplify protocol map definitions with function types #21

merged 5 commits into from
Mar 17, 2023

Conversation

NoamLoewenstern
Copy link
Contributor

Added usage of the "infer" builtin typescript type, to allow easier and prettier type-mapping.
Addresses issue #20

@NoamLoewenstern NoamLoewenstern mentioned this pull request Mar 17, 2023
Closed
@aklinker1 aklinker1 mentioned this pull request Mar 17, 2023
Merged
@aklinker1 aklinker1 changed the title added infer-protocol key type using builtin ts infer. feat(messaging): Simplify protocol map definitions with function types Mar 17, 2023
aklinker1
aklinker1 requested changes Mar 17, 2023
View reviewed changes
Copy link
Owner

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Non breaking, even better :)

packages/messaging/src/index.ts Outdated Show resolved Hide resolved
@aklinker1
Copy link
Owner

I'm adding some type tests. Will push and approve soon.

aklinker1
aklinker1 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Owner

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna update the docs website in a separate PR.

@aklinker1 aklinker1 merged commit a91196d into aklinker1:main Mar 17, 2023
@NoamLoewenstern NoamLoewenstern deleted the infer-return-protocolmap branch March 17, 2023 19:49
@NoamLoewenstern NoamLoewenstern mentioned this pull request Mar 19, 2023
Open
@aklinker1 aklinker1 mentioned this pull request Mar 20, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aklinker1 aklinker1 aklinker1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NoamLoewenstern @aklinker1