Skip to content

Commit

Permalink
Bug 1850987 - Stop sending RecordNotFoundException to crash reporter
Browse files Browse the repository at this point in the history
This is not an actionable error and if we need to know more details
about how often this happens, we should add telemetry instead in a more
meaningful way that would trigger some response.

Right now, no one really seems to look at this data and we are using up
our Sentry event quota unnecessarily.

(cherry picked from commit f51c875242a842b0359bc05f66f0e07ed486bb74)
  • Loading branch information
jonalmeida authored and rvandermeulen committed Sep 1, 2023
1 parent 4e329e0 commit 62eff3a
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import kotlinx.coroutines.launch
import kotlinx.coroutines.plus
import mozilla.appservices.push.BridgeType
import mozilla.appservices.push.PushApiException
import mozilla.appservices.push.PushApiException.RecordNotFoundException
import mozilla.appservices.push.PushApiException.UaidNotRecognizedException
import mozilla.appservices.push.PushConfiguration
import mozilla.appservices.push.PushHttpProtocol
Expand Down Expand Up @@ -304,7 +303,6 @@ class AutoPushFeature(

private fun exceptionHandler(onError: (PushError) -> Unit) = CoroutineExceptionHandler { _, e ->
when (e) {
is RecordNotFoundException,
is UaidNotRecognizedException,
-> onError(PushError.Rust(e, e.message.orEmpty()))
else -> logger.warn("Internal error occurred in AutoPushFeature.", e)
Expand Down

0 comments on commit 62eff3a

Please sign in to comment.