Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark: now compiles on Windows #6

Closed
wants to merge 1 commit into from

Conversation

zenden2k
Copy link
Contributor

Tested on MSVC and Mingw

@aklomp
Copy link
Owner

aklomp commented Sep 14, 2015

But before we can even use the Windows code, we need a build system that works under Windows, right?

@aklomp aklomp self-assigned this Sep 14, 2015
@aklomp
Copy link
Owner

aklomp commented Sep 14, 2015

Please don't take my criticism the wrong way, it's all done with the best intentions.

@aklomp
Copy link
Owner

aklomp commented Sep 22, 2015

Hey, to move this issue forward a little bit, I rewrote your pull request with inclusion of my comments in the branch zenden-new-branch-2. Does this still work correctly on Windows? Any additions/comments?

@zenden2k
Copy link
Contributor Author

Sorry i had a really hard week... did not have time at all.

Compilation of the new branch fails.

#define UNIX_EPOCH 116444736000000000ULL;
  • extra ';'
ts->tv_nsec = ((current_time.QuadPart - UNIX_EPOCH) % 1e7) * 100;
  • error C2297: '%' : illegal, right operand has type 'double'

After fixing that everything works just fine.

@aklomp
Copy link
Owner

aklomp commented Sep 23, 2015

Thanks for testing, should be fixed now. I also learnt that exponential constants have type double and not int like regular numeric constants.

@aklomp
Copy link
Owner

aklomp commented Jan 9, 2024

Thanks everyone for your patience. I felt comfortable working on this patch and merging it now that our CI supports Windows and MinGW (#127). The final commits have changed a bit since this PR, but I couldn't have done it without it. ❤️

@aklomp aklomp added this to the v0.5.2 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants