refactoring

[garak]

This is a first attempt to improve code base, trying to split god class Chess into smaller classes, with less responsibilities.
Some other improvements in code readability (mainly type hinting) is also included.

I have a few ideas for next steps (so for subsequent PRs)

[akondas]

Hey @garak, thanks for contribution, actually this fork was created mainly for performance reasons, I don't know if the flowery code readability is better, but this library is versioned anyway so I'd love to see where it takes us 😉

[akondas]

possibly, if you only want to, can we make a separate library out of it? (with separate independent namespace), for example: chessphp/engine or something like that

[garak]

possibly, if you only want to, can we make a separate library out of it? (with separate independent namespace), for example: chessphp/engine or something like that

That's feasible of course, but what's the purpose?

[akondas]

Clean and solid PHP chess engine for everyone? I leave the decision to you, we can either merge it or do a separate project, let me know.

[garak]

I see, maybe we can drop "Ryans" from namespace? I'll integrate my PR if so

[garak]

So, the choice now would be: how to name it? PHP folks prefer avoiding the use of "PHP" in library names, so "ChessPHP" is not suitable.
What about simply "Chess"?

[akondas]

The name 'chess' is already taken.

[garak]

PChess?

[akondas]

and the repository name? chess?
For example: pchess/chess

[garak]

and the repository name? chess?
For example: pchess/chess

I guess that we can leave that for a second step. For now, we can keep github under akondas/chess.php and using Pchess\Chess as namespace.
When we're ready, we can move to a new repo with consistent name.

If instead you prefer to move now, no problem for me. Create the new repo and let's go with pchess/chess. In such case, you can close this PR and I'll re-do it on such new repo

[akondas]

Bad luck: The name 'pchess' is already taken.

[garak]

On packagist is still available https://packagist.org/explore/pchess (I see a 404)
I guess that here on github you can be creative 😉

[akondas]

php-chess or chessphp,

[garak]

What about p-chess?

[akondas]

https://github.com/p-chess/chess (check e-mail for invitation), thanks for your patience and cooperation

[garak]

Here we are p-chess/chess#1