Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Commit not working on latest 2 releases #476

Closed
andrewmartin opened this issue Jul 1, 2016 · 7 comments
Closed

Commit not working on latest 2 releases #476

andrewmartin opened this issue Jul 1, 2016 · 7 comments

Comments

@andrewmartin
Copy link

For some reason, and I noticed this only happens with the latest 2 releases, when I try and add a commit message, it fails with an error:

Error: ENOENT: no such file or directory, open '/Users/andrewmartin/code/drew-web/.git/COMMIT_EDITMSG'

It does successfully stage the file, just won't save the commit message, which is somewhat frustrating. It was working great for awhile too, that's the strange thing.

I'm currently on 5.15.0 and it's working fine, anything later than that and this error happens.

@akonwi
Copy link
Owner

akonwi commented Jul 1, 2016

To be clear, the commit message file opens, you type your message, try to save the file, and then this message appears.

Is that correct?

@andrewmartin
Copy link
Author

andrewmartin commented Jul 1, 2016

Yep, exactly as you describe.

After I type my commit message and close that window, that little red error notification pops up in the top right corner, and the COMMIT_EDITMSG is essentially not saved. However, if I go to the Terminal and type in git status the file(s) are all staged, and a commit (with message) from there works as expected.

akonwi added a commit that referenced this issue Jul 2, 2016
Only trim the file if the verbose commit feature is enabled
@akonwi
Copy link
Owner

akonwi commented Jul 2, 2016

I've created a branch (476) with what I suspect is the fix. If you don't mind cloning that and replacing your installation of the package with it to give it a shot that would be great.

@andrewmartin
Copy link
Author

@akonwi sorry it took me a bit, this worked!

@andrewmartin
Copy link
Author

@akonwi mind letting me know when it's pushed up or merged into the official release? for now i'm going to use this branch 👍

@akonwi akonwi closed this as completed in 4ea0e4d Jul 6, 2016
@akonwi
Copy link
Owner

akonwi commented Jul 6, 2016

Merged and published 👍

@douggr
Copy link

douggr commented Jul 6, 2016

awesome! many thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants